While others have pointed out your error, and shown you the "Perlish" loop syntax that helps you avoid this type of error, you should know that the filename being random in no way ensures that a file of that name does not already exist, especially in this case if someone calls your subroutine with a small value of $length_limit. Better would be to incorporate a timestamp of some kind in addition to the random characters, but you still need to check that the file does not exist before you start to use the name.

For some other ideas on this topic, please have a look at "unique" filename?, which I located in a few seconds using SuperSearch - try it!

--
I'd like to be able to assign to an luser

In reply to Re: generating random filenames by Albannach
in thread generating random filenames by Amoe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.