He was suggesting that you do something like: 

my $firstbit = ($longsize * 8) - 1;
my $firstbit_mask = 1 << $firstbit;

[download]

then use $firstbit_mask instead of 1 << $firstbit_mask. This cuts down on the number of shifts to do.

As for the second paragraph: 

use constant NUM_BITS = $Config{ivsize} * 8;
use constant SIGN_BIT = 1 << ( NUM_BITS - 1 );
use constant ALL_BITS = -1;

sub sr_signed {
   my ($p, $q) = @_;
   if ($p & SIGN_BIT) {
      return ($p >> $q) | ($ALL_BITS << (NUM_BITS - $q));
   } else {
      return $p >> $q;
   }
}

[download]

Example: 

Shift 10101111...10101100 by 3

     10101111...10101100 >> 3
     ||||||||   |||||
      \\\\\\\\   \\\\\
       \\\\\\\\   \\\\\
        ||||||||   |||||
     00010101111...10101

     11111111...11111111 << (NUM_BITS-3)
                     |||
       _____________///
      ///
     |||
     11100000...00000000

     00010101111...10101
   | 11100000...00000000
     -------------------
     11110101111...10101

[download]

(Note that ivsize should be used, not longsize.)

In reply to Re^3: Implementing a signed/sign-propagating right bitwise shift by ikegami
in thread Implementing a signed/sign-propagating right bitwise shift by LonelyPilgrim

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.