Perl Monks of wisdom,
This is my first post, as I am a complete perl novice. I have written a script utilizing the Net:Snmp module to query load balancing switches. Could some of you please comment on the coding style with suggestions on brevity, alterations and the like? Any comments are greatly appreciated.
#!/usr/bin/perl -w use NET::SNMP; use strict; use vars qw($session $error $response $syscontact $table $oid); Usage() unless(defined $ARGV[0]); Usage() unless(defined $ARGV[1]); ($session, $error) = Net::SNMP->session( -hostname => $ARGV[0], -community => $ARGV[1] ); die "session error: $error" unless ($session); my $tableid = "1.3.6.1.4.1.1991.1.1.4.6.1.1"; $table = $session->get_table($tableid); die "request error: ".$session->error unless (defined $table); foreach $oid (keys %$table) { if ($oid=~/1.3.6.1.4.1.1991.1.1.4.6.1.1.4.[0-9]+/) { my @digits = split (/\./, $oid); my $enddig = $digits[-1]; my $rsportoid = "1.3.6.1.4.1.1991.1.1.4.6.1.1.5.$enddig"; my $vsnameoid = "1.3.6.1.4.1.1991.1.1.4.6.1.1.2.$enddig"; my $vsportoid = "1.3.6.1.4.1.1991.1.1.4.6.1.1.3.$enddig"; print "Real server ".$table->{"$oid"}.", port ".$table->{"$rsportoi +d"}.", is bound to virtual server ".$table->{"$vsnameoid"}.", on port + ".$table->{"$vsportoid"}."\n"; } } $syscontact = $session->get_request("1.3.6.1.2.1.1.4.0"); die "request error: ".$session->error unless (defined $syscontact); print "For help or questions contact: ".$syscontact->{"1.3.6.1.2.1.1.4 +.0"}."\n"; $session->close; sub Usage{ print( "\n", " You didn't provide target hostname or IP address and community s +tring!\n", " Usage: snmp1.pl host_ip|name community_string\n", " Net::SNMP $Net::SNMP::VERSION\n"); exit 1; }
Thank you for your time,
Jer

In reply to Net::Snmp Attempt by Jer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.