I would write is as follows:
#!/usr/bin/perl -w use strict; use Net::SNMP; Usage () unless @ARGV == 2; my ($session, $error) = Net::SNMP -> session ( -hostname => $ARGV [0], -community => $ARGV [1], ); $session or die "Session error: $error"; my $tableid = "1.3.6.1.4.1.1991.1.1.4.6.1.1"; my $table = $session -> get_table ($tableid) or die "request error: ", $session -> error; foreach my $oid (keys %$table) { if ($oid =~ /^\Q$tableid\E\.(\d+)/) { print "Real server ", $table -> {$oid}, ", port ", $table -> {"$tableid.5. +$1"}, ", is bound to virtual server ", $table -> {"$tableid.2. +$1"}, ", on port ", $table -> {"$tableid.3. +$1"}, "\n"; } } my $sysid = "1.3.6.1.2.1.1.4.0"; my $syscontact = $session -> get_request ($sysid) or die "Request error: ", $session -> error; print "For help or questions contact: ", $syscontact -> {$sysid}, "\n" +; $session -> close;
Some differences: no global variables (with use vars). No magical constants that are repeated. Taken care of the special meaning of a dot inside a regex. Anchored the regex. Used parenthesis to capture relevant field. No needless concatenation in print or die. Success is checked right away and not in a separate statement. Just one check to see if there are enough arguments.

-- Abigail


In reply to Re: Net::Snmp Attempt by Abigail
in thread Net::Snmp Attempt by Jer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.