Ok, aside from -Tw and use strict; here's a few other suggestions..
In your param snarfing part, you might want to use something that works with defaults..
for example:
$across = param('across') ? param('across') : $across_default;
$down = param('down') ? param('down') : $down_default;
$team = param('team') ? pram('team') : $team_default;
# $move is safe, will use defaults or set params
$move = $down."_".$across;
CGI::Carp would be a good thing for error reporting (where the file open may die).
You open files inside if (param()) { but try and close them outside of the block.. it wont error, but it's ugly.
and lastly, probably more of a nitpick, you have a ton of file opening and closing.. there's probably a better way to handle that (like rewinding file)
-Syn0
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.