%dictionary is a hash. You are passing it as a hash reference argument to
readWords() and
sortDictionary(), via
\%dictionary. So far so good.
Now, inside the functions
readWords() and
sortDictionary(), you need to consume the argument you passed in. But your code currently does not do that. (Instead, it is consuming the closed-over lexical
my %dictionary - if you don't understand this last sentence, ignore it for now).
Let change your functions to consume the passed in hashref. To avoid confusion, I renamed the variable inside the functions to be
$dict instead. Here's the same code with modifications indicated:
my %dictionary;
readWords(\%dictionary);
sortDictionary(\%dictionary);
sub readWords {
my ($dict) = @_; # <<--- grab hashref argument
$numWords = 0;
open FILE, $ARGV[0] or die $!;
while (my $lines = <FILE>) {
$numWords++;
chomp $lines;
my ($words, $definitions) = split('/', $lines);
$words = lc($words);
$dict->{$words} = $definitions; # <<--- renamed $dictionary to $
+dict
}
foreach $key (%{ $dict }) { # <<--- use $dict exclusively, but as
+the hash it's pointing to
print $dict->{$words}; # <<--- renamed $dictionary to $dict
print $result . "\n";
}
close FILE;
}
sub sortDictionary {
my ($dict) = @_; # <<--- grab hashref argument
foreach my $key (sort keys %{ $dict }) { # <<--- use $dict exclusi
+vely, but as the hash it's pointing to
$key =~ /^(.)/;
my $line = $key . '/' . $dict->{$key} . "\n"; # <<--- renamed $d
+ictionary to $dict
print $line;
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.