Unrelated to your question, but in the interests of improving your style you may find the following of interest:
#!/usr/bin/perl
use strict;
my $directory = "D:\\FTP-Accounts\\upload";
my $kMaxHours = 1;
my $count;
print "\n";
opendir my ($scan), $directory or die $!;
while (my $name = readdir($scan)) {
#next unless (-f "$directory/$_");
my $age = -M $name;
print "$name - Days = $age\n";
$age *= 24;
if ($age > $kMaxHours) {
++$count;
print " * Triggersed * Hours = $_\n\n";
}
}
closedir $scan;
print "\nFile Count - $count -\n";
if (! $count) {
print "OK:";
exit 0;
}
print "\nWarning: file is older than $kMaxHours hours\n";
exit 1;
Points to note:
- the k prefix in $kMaxHours as a convention to indicate a "constant"
- Use a lexical handle for the directory scan handle ($scan)
- use explicit variables instead of overuse of the default variable to make code easier to understand ($age, $name)
- Use early exit to avoid needless nested code and repeated tests (<c>if (! $count) ...
There may be other minor changes - can you spot them?
True laziness is hard work
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.