I think you're making it way too complicated. In-place editing, when you don't know what you're doing, can wipe out your files. And besides, it's not really editing in-place. It makes an optional backup copy of the file, but it always writes a new file.

There's probably a module for this (such as Iterator::Diamond, noted here), but it's easy enough to do yourself also. Here's something simple, that is probably more reliable than what you're doing.

# Assumes you are using strict -- RIGHT?
{
    # Need to add tags of <vom> and <\vom> at the start and 
    # end of the file.

    # Changing '\' to '\\' is not wrong, but you can also use
    # '/' on Windows. Perl handles it just fine, and it's a lot
    # easier to read. It's optional here since you're not dealing
    # with the filenames directly.
    $out->[1] =~ s{\\}{/}g;

    # First, create a backup name and rename the original file. This
    # creates your backup file, and we'll create your "original" in
    # a moment.
    my $bk = $out->[1] . ".bk";
    rename $out->[1], $bk;

    # Open the backup for input.
    open my $f, '<', $bk or die $!; 

    my $data; # Use this to capture data.
    # Old-style slurp mode.
    {
        local $/ = undef;
        $data = <$f>;
    }

    # Now open the original filename, reusing the filehandle, and
    # write to it.
    open $f, '>', $out->[1] or die $!;
    print $f "<vom>\n", $data, "\n</vom>\n";
    close $f;                    # All done.
}

[download]
--marmot

In reply to Re^4: In place edit does not work on Windows by furry_marmot
in thread In place edit does not work on Windows by sumeetp45

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.