It's not clear what you're doing with both @pictures and $picture. You should remove the line that is marked broken, and change the loop over the pictures to:


sub make_barn
        {
        my($barns_path);
        my($picture);
        my($barn_number, @barns);
        my($barn, $member);
                
        $barns_path = './barns';
        
        $barn = Archive::Zip->new();
        
        foreach $picture (@_)
                {
                $member = $barn->addFile($picture);
                $member->desiredCompressionLevel(9);
                print "Added $picture\n";
                }

[download]

And you've made a very good decision to use Archive::Zip :-)

In reply to Re: Recieving lists as arguments by bikeNomad
in thread Recieving lists as arguments by Amoe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.