For sure someone else will answer you about the cookies, but, please tell me:
- Wy do you use local here? I think you want to use lexical variables here and those are declared with the my keyword.
- Why did you prefix your subroutine calls with the & sigil? Are these subroutines prototyped and you want to avoid the prototype checks? write_cookies isn't prototyped so you should drop the &. It serves no useful purpose.
Also, I try not to have variables inside my subroutines that are not passed in as parameters, unless it are really and truly global variables:
sub write_cookies{
my ($username, $password, $regtype, $expires) = @_;
print "Set-Cookie: reguser=$username; expires=$expires; path=/;\n
+";
print "Set-Cookie: regpass=$password; expires=$expires; path=/;\n
+";
print "Set-Cookie: regtype=$regtype; expires=$expires; path=/;\n"
+;
}
And then call the sub as follows:
write_cookies($username, $password, $regtype, calc_cookie_expires(-1))
+;
CountZero
A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James
My blog:
Imperial Deltronics
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.