Your flag is working and breaking you out of your while loop just fine. However, you call your dirname() sub for every image found. If you put a line like the following at the beginning of your sub, you'll see what's happening: 

print "Entering sub dirname\n";

[download]

For readability, I'd get rid of the flag variable altogether by putting my test in the while condition. I also find it awkward to have a break out of the first half of an if-else with the major work in the second half. (Not wrong, just awkward.) So I'd do something like this: 

sub dirname {
    print "Entering sub dirname\n";
    my $word = "site";
    my $counter = 1;
    my $name;
    do {
        $name = $word . "_" . $counter++;
    } while( -e $name);
    mkdir $name, 0755 or warn "Cannot make dir $name:  $!";
    print "$name \n";
}

[download]

Aaron B.
My Woefully Neglected Blog, where I occasionally mention Perl.

In reply to Re: getting a while loop to terminate by aaron_baugher
in thread getting a while loop to terminate by Aldebaran

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.