Here's a somewhat simpler and more idiomatic version of your code that does the same thing that may help you. Ask about anything you do not understand:

#!/usr/bin/perl -w use strict; my( @arrayx, @arrayy, @arrayz ); while (<>) { # Find x, y, z coordinates and store in separate arrays if ($_ =~ /^ATOM/) { my @line = $_ =~ m/^(.....).(.....).(....).(...)..(....)....(. +.......)(........)(........)/; ## using push mean you don't have to count because ... push @arrayx, $line[5]; push @arrayy, $line[6]; push @arrayz, $line[7]; } } close *ARGV; ## prevent confusing error message suffixes # Calculate distance between all atom coordinates ## ... $#xxx gives you the highest index in array @xxx foreach my $i ( 0 .. $#arrayx ) { foreach my $j ( $i + 1 .. $#arrayx ) { my $dist = sqrt( ($arrayx[$i] - $arrayx[$j])**2 + ($arrayy[$i] - $arrayy[$j])**2 + ($arrayz[$i] - $arrayz[$j])**2 ); ## Adding $i and $j to your output will let you know what that + output is. print "$i <> $j : $dist\n"; } }

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.

The start of some sanity?


In reply to Re: Calc distance between atoms in pdb file by BrowserUk
in thread Calc distance between atoms in pdb file by stellaparallax

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.