I would appreciate any input on 1) code correctness
use strict;
use warnings;
open(IN, "list.txt") or die;
chomp($line = <IN>);
($a, @ss) = split /\s+/, $line;
while (chomp($line = <IN>)) {
($aa, @prs) = split /\s+/, $line;
for ($i=0; $i<@prs; $i++) {
$s{$aa}{$ss[$i]} = $prs[$i];
}
}
close(IN);
I would write that code as:
use strict;
use warnings;
open my $IN, '<', 'list.txt' or die "Cannot open 'list.txt' because: $
+!";
my ( undef, @ss ) = split ' ', <$IN>;
my %s;
while ( <$IN> ) {
my ( $aa, @prs ) = split;
@{ $s{ $aa } }{ @ss } = @prs;
}
close $IN;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.