sub isprime($) { my $num = $_[1]; $primer = 1; $ValidChars = "2357"; $str = $num; if (index($ValidChars, ord(substr $str, 0, 1)) == 1) { $primer = 0; } return $primer; }
That returns 1 unless the first character of the first argument (assuming you fix the already noticed error regarding $_[1]) equals 3. I think you are calling isprime only with single digit numbers, and want to return if the digit is a prime number. I'd write that as:
sub isprime {$_[0] =~ /^[2357]$/}
although I would fix the name. Or just inline the test -- that's a lot clearer than any name I can think of.
if (($n != 1) && ($n != 0)) { if (isprime($n)) { $prime += $n; } if (!isprime($n)) { $comp += $n; } }
Too many ifs, and too many calls to isprime. I'd write that as:
if ($n =~ /^[2357]$/) { $prime += $n; } elsif ($n !~ /^[01]$/) { $comp += $n; }
Or, when I'm in the mood for something funky, as a ternary returning an lvalue.
$text.length
That should be spelled length($text).

In reply to Re: Javascript to Perl = fail by JavaFan
in thread Javascript to Perl = fail by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.