This will allow you to grab less data at one whack. I'll also throw in some prettier constructs which use fewer temporary variables.

#!/usr/bin/perl -w

use strict;
use DBI;
use Finance::QuoteHist;

my $user="me";
my $password="pass";
my $database="stocks";

my $dbh=DBI->connect("dbi:mysql:$database",$user,$password,{RaiseError
+=>1})
    or die "Cannot connect to database";

my $syms = $dbh->selectcol_arrayref("Select symbol from symbols");

my $sth=$dbh->prepare("INSERT INTO stocks
                       (symbol,date,open,high,low,close,volume,adjuste
+d)
                       VALUES(?,?,?,?,?,?,?,?)");

for (@{$syms}) {
    my $q = new Finance::QuoteHist(
        symbols => [$_], # just one symbol    
        start_date => '01/01/2001',
        end_date => 'today');

    for ($q->quotes()){
        $sth->execute(@{$_});
    }
    #next stock symbol now
}
# done

$dbh->disconnect();

[download]

The selectcol_arrayref call is relatively new in DBI.pm. If it's unavailable, what you have will work just fine.

After Compline,
Zaxo

In reply to Re: Help with Finance::QuoteHist by Zaxo
in thread Help with Finance::QuoteHist by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.