for my $elem ( @a ){
    push @z, $_ = ( first { $elem eq $_ } @b ) ? '+' : '-';
}

[download]

One problem with this code is that  first returns the first element from  @a that is also present in  @b. If there is a 0 in both  @a and  @b a 0 will be returned. Numeric 0 is false, which will cause the ternary to select the '-' character representing element not present.

In addition, the code needlessly assigns to the  $_ scalar. In the example below, comment out the  local $_; statement and see what happens to the  $_ scalar.

IMHO, using  any (as in the OPed code) is far better. The job can also be done with the  map built-in rather than a  for loop. 

>perl -wMstrict -MData::Dump -le
"use List::Util      qw(first);
 use List::MoreUtils qw(any);
 ;;
 my @a = (1, 2, 3, 4, 5);
 my @b = (9, 8, 2, 1, 5);
 my @z;
 ;;
 $_ = 'foo';
 { local $_;
   for my $elem ( @a ){
     push @z, $_ = ( first { $elem eq $_ } @b ) ? '+' : '-';
     }
   }
 print @z;
 print qq{\$_ == '$_'};
 ;;;;
 @z = ();
 for my $elem (@a) {
   push @z, (any { $_ == $elem } @b) ? '+' : '-';
   }
 print @z;
 ;;;;
 @z = map { my $ae = $_;  (any { $ae == $_ } @b) ? '+' : '-' } @a;
 print @z;
"
++--+
$_ == 'foo'
++--+
++--+

[download]

Update: Another oops. In the first for-loop example above, the statement
    push @z,  ( first { $elem eq $_ } @b ) ? '+' : '-';
was intended to exactly duplicate the corresponding statement in the post to which I was responding. I took out the  $_ = assignment to test something, then forgot to put it back. I have now put the assignment back; the output is the same, and removing the  local $_; statement now will really change the output.

In reply to Re^4: Failed array attemp by AnomalousMonk
in thread Failed array attemp by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.