I have two arrays and if an element in 1st array is in 2nd array I want to append "+" to array 3. If it's not I want to append '-' to array 3.

Just doing exactly what you say you want (and using numeric comparison because you did) would give: 

for my $x (@x) { push @z, (grep {$_ == $x} @y) ? '+' : '-'; }

[download]
If your arrays stay short, this method might be fine, but you might want to avoid iterating over @y for each and every element of @z. A better way to do it would be: 
my %k = map {($_, 1)} @y;
for my $x (@x) { push @z2, (exists $k{$x}) ? '+' : '-'; }

[download]
And if this is something you are doing a lot, you should just wrap it up in a sub so you can call it with references to two arrays and get a reference to a newly constructed array in return.

Don't worry about having short code. My second example is a little longer but still more efficient. You should focus on writing good and readable code and then reusing it properly.

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: Failed array attemp by sauoq
in thread Failed array attemp by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.