Hi hector89,

The problem is that readdir returns the names of files (or directories) in the specified directory, but not their paths. So you need to either:

chdir $dirName;
[download]

before entering the foreach loop, or else add:

$txtfile = $dirName . '\\' . $txtfile;
[download]

at the start of the code within the loop to prepend the directory path to each filename.

You probably would have seen this yourself if you had included:

use warnings;
[download]

at the start of your script.

Here is a working version with a little sanity checking added:

#!/usr/bin/perl
use strict;
use warnings;

(my $prog_name = $0) =~ s| ^ (?: .* [\\/])? (.*) \.pl $ |$1|x;

(my $dirName = $ARGV[0])
    or die "Usage: $prog_name <directory>";

opendir(DIR, $dirName)
    or die "Unable to open directory '$dirName': $!";
my @files = grep(/ \.txt $ /x, readdir(DIR));
closedir(DIR);

chdir $dirName;     # <-- EITHER add this

foreach my $txtfile (@files)
{
  # $txtfile = $dirName . '\\' . $txtfile;     # <-- OR add this

    print "$txtfile\n";

    open(my $input_fh, '<', $txtfile)
        or die "Unable to open file '$txtfile' for reading: $!";

    undef($/);
    my $file = <$input_fh>;

    close $input_fh;

    $file =~ s/(<%--)?\s*<script(.*?)>/($1 ? '' : "\n<%-- ") . "<scrip
+t$2>"/ige;
    $file =~ s=</script>\s*(-->)?='</script>' . ($1 ? '' : " -->\n")=i
+ge;

    print $file;

    open(my $output_fh, '>', $txtfile)
        or die "Unable to open file '$txtfile' for writing: $!";
    print $output_fh $file;
    close $output_fh;
}
[download]

HTH,

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.