A few things to keep in mind as you write more code.

• Always use strict;
• use autodie;
• When opening file handles, don't use a bare file handle. For example, use $file instead of file
• When opening file handles, use three arguments: open my $fh, '>', $filename (see this for a brief explanation)
• I strongly recommend explicitly naming your variables if you and/or your colleagues are learning perl. It can make the code much more readable; for example, compare your while loop to mine.

I quickly cleaned up the code you posted according to my suggestions so you can see them side-by-side:

#!/bin/perl5.8.6
use strict;
use warnings;
use diagnostics;
use File::Basename;

my @files = <../tryremove/*>;

#This is the destination path where the comment removed files are crea
+ted.
my $path1 = "C:/Projects/tryremove/c";

foreach my $file (@files) {
    my $filename = basename($file);
    open $file1, "<", $file;
    open $file2, ">", "$path1/$filename";

    while ( my $line = <$file1> ) {
        $line =~ s# .* report s? .* ; .* ##sx;
        print $file2 $line;
    }

    close $file1;
    close $file2;
}
[download]

Disclaimer: It's late and I'm pretty sleepy. Although I think it should be fine, test it to make sure it behaves the same as your fixed script!

- Mike

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.