Hey Monks,

I've got some code smell and I can't find the right cleaner. I'm looking to combine the following two functions. I ended up writing them real quick to get another module finished, but I don't like the repitition. I've got a feeling that I'm not really being pragmatic or not using the right tools. Without further ado: 

# Simple num item in list check
sub is_in_num
{
    my ($item, $l1) = @_;

    foreach my $e1 (@$l1)
    {
        if ($e1 == $item)
        {
            return 1;
        }
    }
    return 0;
}

# Simple str item in list check
sub is_in_str
{
    my ($item, $l1) = @_;

    foreach my $e1 (@$l1)
    {
        if ($e1 eq $item)
        {
            return 1;
        }
    }
    return 0;
}

[download]

Did a bit of searching and didn't find any elegant solutions, but this is a pretty simple problem so maybe it doesn't demand such attention

Ransom

In reply to Better way to write these checks? by Ransom

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.