First of all please try to follow basic guidelines in your code.
- Check if open() actually worked.
- Use consistent indentation to make the codeflow easier to follow (perltidy can do this for you).
- You should use strict; use warning;
- For better scoping, put open and close within the sub
- Subs are generally called like findLines();
- Use named variables instead of the implicit $_
Here's some pseudo-code on how to return an array:
use strict;
use warnings;
use Data::Dumper;
sub findLines {
open(my $error_fh, '<', 'iset_error_log') or die($!);
my @lines;
while((my $line = <$error_fh>)) {
next unless($line =~ /\[notice/); skipp all lines except notic
+e
# yada, do something to $line
push @lines, $line;
}
close($error_fh);
return @lines;
}
my @found = findLines();
print Dumper(\@found);
To be more memory efficient, you could also return a reference to the array, like this:
# .....
close($error_fh);
return \@lines;
}
my $found = findLines();
print Dumper($found);
Sorry for any bad spelling, broken formatting and missing code examples. During a slight disagreement with my bicycle (which i lost), i broke my left forearm near the elbow. I'm doing the best i can here...
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.