Here are some minor suggestions:
- Allow the data to be specified on the command line. Having to type the values on separate lines can be inconvenient in some situations.
- Turn on warnings.
- Handle EOF (or an error) when reading from STDIN.
- Environment variables are usually given a value type of REG_EXPAND_SZ (instead of the default REG_SZ that you used) so that they can be, for example, "%SystemRoot%\\system32".
- Check for failure on the insert.
Which results in something like this:
#/usr/bin/perl -w
use strict;
my $Reg;
use Win32::TieRegistry (
TiedRef => \$Reg,
ArrayValues => 1,
Delimiter => '/',
':REG_'
);
my( $Host, $Key, $Value )= @ARGV;
# Asking for machine name and info to be added to the sys env var
if( ! defined $Host ) {
print "What host would you like to connect to? ";
$Host= <STDIN> or exit;
chomp $Host;
}
if( ! defined $Key ) {
print "What name would you like for the Sys Environment Variable?
+";
$Key= <STDIN> or exit;
chomp $Key;
}
if( ! defined $Value ) {
print "What value would you like to assign to this variable? ";
$Value= <STDIN> or exit;
chomp $Value;
}
# this is the system environment variable area done on the registry
my $SysEnv= $Reg->Connect("$Host", "LMachine/System/CurrentControlSet/
+Control/Session Manager/Environment/")
or die "Can't connect to $Host 's registry or can't open Registry
+ key, Session Manager/Environment: $^E
+\n";
# create a new value and set its data
$SysEnv->{"/$Key"} = [ $Value, REG_EXPAND_SZ ]
or die "Can't create $Key ($Value): $^E\n";
-
tye
(but my friends call me "Tye")
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.