A couple of style comments may help:
Use three parameter open and lexical file handles (open my $out, '>', "$outfile") or die "Cannot open $outfile :$!";). The lexical file handle would have caught your OUT/OUTFILE issue at compile time.
Use "early exits" to make code clearer and to avoid extra levels of nesting. The case in point is your "No hits found" test. By rewriting it as:
if ($result->num_hits == 0) {
#"No Hits found" case:
print OUT "\n No hits found \n";
next;
}
you don't require the else part of the statement - that code simply follows the if and is executed only when the if condition is false (the next following the print statement effectively skips the following code).
True laziness is hard work
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.