Hello dr.jekyllandme,

Neighbour has dealt with the main problem — the inappropriate recursion — in your code. However...

If anyone can give me pointers how to improve my code, it would be great. Thank you.

Well, since you asked...  ;-)

• Always  use strict;


• Always  use warnings;


• Prefer lexical filehandles (with lowercase names):  my $fh


• Use the 3-argument form of open:

  open(my $fh, '>', 'my_file.txt');
  [download]

• Either use autodie; at the head of your script, or else add

  or die "...";
  [download]

  after every open and close.


• Do not use the & sigil when calling functions:

  edit_file('my_file.txt');
  [download]

• If using the default variable $_, you often don’t need to name it explicitly:

  open(my $fh, '<', $myfile) or die "Unable to open file\n";
  
  while (<$fh>)
  {
      chomp;             # <-- here and
      unless (/^[a-z]/)  # <-- here
      {
          ...
  [download]

HTH,

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.