#!/usr/bin/perl -w
use strict;

#This program asks for an input file, output file, a string, 
# and a replacement string.  It then searches the input file 
# for the string and substitutes it with a phrase of the
# user's choice.

#get user input...
#there are many problems with this code...

#Open the file, perform the substitutions, and create the 
#   new user named file.
open (READFILE, "$infile") 
        || die "Can not open input file $infile: $!" ;
open (WRITEFILE, ">$outfile") 
        || die "Can not create outfile $outfile: $!;
while (<$infile>) {  ### PROBLEM ###
                     ### Should use READFILE, the file handle ###
                     ### instead of the string "$infile" ###
                     ### while (<READFILE>) ###
    print WRITEFILE "$_" ;
}

[download]
The $! variable can be useful, but it is often not.
This is basically the OS error code text. That does not normally contain the file name that that was "under question".
If want to "die" or "warn", then I would echo the file name that didn't work.

In reply to Re: Newby question by Marshall
in thread Newby question by Parmenides

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.