Dear Monks,

I made this script to find where a value is along an array. This code is pretty explicit and works as expected, but I am looking for advice on improving its efficiency or elegance before implementing it further.

use strict; use warnings; use List::Util qw(max min); my @array = (11, 23, 40, 52, 67); my ($minarray, $maxarray); my $lookup = $ARGV[0]; my ($prev, $curr); $minarray = min(@array); $maxarray = max(@array); foreach my $i (@array){ if ($lookup < $minarray or $lookup > $maxarray){ print "$lookup is out of bounds\n"; last; } if ($i == $lookup) { print "Exact match $i\n"; last; } unless ($prev) { $prev = $i; next; } if ($i < $lookup) { $prev = $i; next; } else { $curr = $i; } if ($curr > $lookup) { print "Value $lookup, is between $prev and $curr\n"; last; } } # >perl lookupArray.pl 27 # Value 27, is between 23 and 40
Thanks and best regards

Update: Minor edit to correct as per BillKSmith's observation.
And many thanks to all for the nice variants and improvements offered. Cheers!


In reply to Improve my lookup script by jjap

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.