You didn't mention in what way(s) it's not working. That's important info for anyone trying to help you debug.

One issue I noticed is that you're going to run passed the end of @dude. The scalar value returned by @dude is the number of elements it contains. @dude+1 is one more than the number of elements.

Another issue is here: file"+"$0.txt ". Perl doesn't concatenate strings using '+'. It uses the dot operator for that. But it's not even necessary. You could write it as file$0.txt".

Here's a reworked version. I won't be debugging your system call, and don't know if it's even an issue:

use strict;
use warnings;

open FILE, '<', "dns.txt" or die $!;

while (my $line = <FILE>) {
  my ($ip) = $line =~ /(\d+\.\d+\.\d+\.\d+)/;
  system("ssh a.AS1 traceroute $ip > file$ip.txt");
}

[download]

Dave

In reply to Re: how to save result in multiple files using for loop in perl by davido
in thread how to save result in multiple files using for loop in perl by zakishah

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.