Great suggestions have been given. Here's are some other observations/suggestions:
- Use a three-argument open.
- Use lexical file handles, e.g., my $fh, instead of FILE.
- Your first while reads all lines from the file, so there are none left for the second while
- Use lexical variables throughout.
- Your if(/\b$s\b/) matches against $_ when you've assigned a file line to $line.
- close the file when your done with it.
Give the above, consider the following:
use strict;
use warnings;
my ( @IPS, $IP );
print "Enter name:\n";
my $s = <>;
chomp $s;
open my $fh, '<', 'routers.txt' or die $!;
while ( my $line = <$fh> ) {
if ( $line =~ /\b$s\b/ ) {
my ($IP) = $line =~ /(\d+\.\d+\.\d+\.\d+)/;
push( @IPS, $IP );
}
}
close $fh;
print "$_\n" for @IPS;
Hope this helps!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.