The error is not in the subroutine.

In your script when you call create_output     (@array_of_lines, $entry_no_new); the array is empty since you never put anything into @array_of_lines.

You are getting yourself confused because in the look_through_file subroutine you also declare an @array_of_lines array and fill it with data. BUT as this is a lexical array scoped to this subroutine only (and totally separate of the lexical @array_of_lines declared in the main body of your script), it will simply disappear at the end of the subroutine, taking all its data with it.

There are two solutions:

  1. use the @array_of_lines declared in the main body of your script also in the subroutine. In other words, do not do a my @array_of_lines in your sub. THIS IS THE BAD SOLUTION!
  2. Take the return value from your look_through_file sub and put that in the @array_of_lines array declared in the main body of your script. You will have to re-adjust the return parameters of that sub and put the array at the back or the returned scalar values will get eaten by the array.

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

My blog: Imperial Deltronics

In reply to Re^3: problems passing variables between subroutine by CountZero
in thread problems passing variables between subroutines by Freezer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.