Consider the following:

sub find_above_average {
    my $mean = &calculate_average(@_);

    return grep $_ > $mean, @_;
}

[download]

Remove the say line and print the average outside of the subroutine, and use grep to return only those values greater than the value of $mean.

sub calculate_average {

    @_ > 0 or die 'No numbers sent for averaging.';

    my $sum = 0;
    foreach (@_) {
        $sum += $_;
    }

    return $sum / @_;
}

[download]

Check for an empty list at the top to avoid a division by zero error.

In reply to Re: Any improvement over the code possible?? by Kenosis
in thread Any improvement over the code possible?? by Rohit Jain

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.