I think I'd like to see a looser coupling between find_above_average and calculate_average. And I would move the prints outside of the subroutines, to make them more generic.

use v5.14;
use warnings;
use IO::Interactive qw( is_interactive );
use Scalar::Util qw( looks_like_number );
use List::Util qw( sum );


say "Enter a list of numbers to find above average numbers, one per li
+ne:"
    if is_interactive;
my @numbers = get_input();
say "No numbers entered. Exiting" and exit if ! @numbers;
my $average = average( @numbers );
say "The average is $average";
say "The above-average numbers are:";
say "\t$_" for above_average( $average, @numbers );


sub average {
    return sum( @_ ) / @_;
}

sub above_average {
    my $average = shift;
    return grep { $_ > $average } @_;
}

sub get_input {
    chomp ( my @numlist = <STDIN> );
    return grep { length $_ && looks_like_number($_) } @numlist;
}

[download]

Update: s/&&/and/ to fix a precedence issue.

Dave

In reply to Re: Any improvement over the code possible?? by davido
in thread Any improvement over the code possible?? by Rohit Jain

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.