Please suggest improvements

Just a quick observation: In this part of the code:

sub push_button4
 {
 sub push_button1();
 $txt->insert('end',"Opened $filename1\n");
 sub push_button2();
 $txt->insert('end',"Opened $filename2\n");
 sub push_button3();
 $txt->insert('end',"Opened $filename3\n");

...

[download]

I’m guessing you meant to call subroutines push_button1, push_button2, and push_button3, in which case you need to remove the three occurrences of sub. In its current form, the code is simply declaring that each of these subroutines is prototyped to take no arguments (which is probably wrong, and is certainly unnecessary) — but it isn’t calling (i.e., invoking) them.

Hope that helps,

Athanasius <°(((>< contra mundum

In reply to Re^5: Parsing multiple excel files in perl by Athanasius
in thread Parsing multiple excel files in perl by reaper9187

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.