in reply to Increase efficiency of script

You may be looking in the wrong place for optimization.

If you run the script from the command line how long does it take to execute? The script doesn't look excessively slow. But loading 250k into your browser (over a telephone line) takes awhile.

On a style point, do you really need to create $data1, $data2, and $data3, only to load them into a hash later?


Dave

Replies are listed 'Best First'.
Re: Re: Increase efficiency of script
by jonnyfolk (Vicar) on Mar 20, 2004 at 08:49 UTC
    Thanks for looking it over Dave - I thought it might be a browser issue (IE5 for Mac is not the quickest around) but thought I'd check out the code.

    I created the hash manually to associate the file name with the file - if there's another/better way to do that I'd be very interested to know.

[reply]
      I created the hash manually to associate the file name with the file - if there's another/better way to do that I'd be very interested to know.

      If you must hardwire the filenames, I don't have anything against using a hash to store them. I just might not have bothered with the intermediate scalar variables: 

      my  $data2="/home/users/some_path/edit/data2.txt";
my  $data1 ="/home/users/some_path/edit/data1.txt";
my  $data3 ="/home/users/some_path/edit/data3.txt";

my %dbs = (
            Data1        =>    $data1,
            Data2        =>    $data2,
            Data3        =>    $data3,
);

      [download]

      ...could be written more legibly as: 

      my %dbs = (
    Data2 => "/home/users/some_path/edit/data2.txt",
    Data1 => "/home/users/some_path/edit/data1.txt",
    Data3 => "/home/users/some_path/edit/data3.txt",
);

      [download]

      But that's, as I mentioned, just a style issue. I may be out of style myself. ;)


      Dave

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom