in reply to greping for a word

Here's a quickie: 
use warnings;
use strict;
use File::Find;

my $search_string = "ORA";
find( \&grep, "." );

sub grep
{
    my $file = $File::Find::name;
    if ( -f $file && -r _ ) {
        open( my $fh, "<", $file ) or return;
        while ( my $rec = <$fh> ) {
            print "Found $search_string in $file" 
              if $rec =~ /$search_string/;
        }
    }
}

[download]
However, if you have access to Unix, then the following shell snippet might be more useful in the long run: 
find . -type f | xargs grep -l ORA

[download]

thor

Replies are listed 'Best First'.
Re: Re: greping for a word
by jdporter (Paladin) on Apr 29, 2004 at 03:40 UTC
    xargs? blech. 
    find . -type f -exec grep -l ORA {} \;

    [download]
[reply]
[d/l]

      [Inevitable off-topic discussion ensues]

      With a large amount of files (and with hundreds of directories, we can assume there are a large amount of files. Either that or someone has designed a very bad filesystem layout), using -exec with find can be substantially slower than using xargs. The reason being that -exec forks once for every file, whereas xargs will pack as many arguments on a single command line as possible. This is not only conceptually cleaner (imho), but like I said, with lots of files it's noticeably faster.

      Update: Just to test my assertions, I ran a test to see what the difference was. As you can see, the directory I'm running this in has 29,388 files. Granted this benchmark might not be representative of the actual post, but the difference is quite dramatic. Maybe I've done something wrong:

      $ time find ./ -type f | wc -l
29388
 
real    0m0.244s
user    0m0.034s
sys     0m0.181s

$ time find ./ -type f -print0 | xargs -0 ls | wc -l
29388
 
real    0m1.049s
user    0m0.420s
sys     0m0.588s

$ time find ./ -type f -exec ls '{}' \; | wc -l
29388
 
real    0m46.239s
user    0m16.509s
sys     0m25.974s

      [download]

      I ran each test multiple times, and posted the lowest time for each.

[reply]
[d/l]
[select]
        Yowch!     xargs++ :-)
[reply]
[d/l]

In Section Seekers of Perl Wisdom