So, if you want to spit the image back to the browser you can do something like what you've already done. On the other hand, if you want to save the file to the server for safe keeping you can:

        # Copy a binary file to somewhere safe
        open (OUTFILE,">>/usr/local/web/users/feedback");
        while ($bytesread=read($filename,$buffer,1024)) {
           print OUTFILE $buffer;
        }
[download]

Gary Blackburn
Trained Killer

#!/usr/bin/perl -w

use strict;

my $file = "/etc/passwd";
my $data;

open(FILEHANDLE, "$file") || die "Can't read $file: $!\n";

print $data while(read(FILEHANDLE, $data, 1024));

close(FILEHANDLE);
[download]

#!/usr/bin/perl -w

use CGI qw/:standard/;

print header();
print start_html();
print start_multipart_form(-action=>'test.pl');
print filefield('file_name'), submit();

print end_form;
print end_html;
[download]

#!/usr/bin/perl -w

use strict; ## ALLWAYS!!!!
use CGI;
use CGI::Carp qw(fatalsToBrowser);
$CGI::POST_MAX=1024 * 25;
my $q = new CGI;
my $file_name = $q->param('file_name');
my $fh = $q->upload('file_name'); # this is needed because use strict
if($fh) {
   open OUT, ">/tmp/output.gif" || die "cannot open: $!";
   binmode OUT; #just in case you are under windows
   print $q->header('image/gif');
   my $data;
   while(read($fh,$data,1024)) {
     print $data;
     print OUT $data;
   }
   close OUT;
}
else {
  print $q->header();
  print $q->start_html();
  print $q->h1('no upload file');
  print $q->end_html();
}
[download]

Try calling binmode before you start printing:

binmode FILEHANDLE;
print $data while(read(FILEHANDLE, $data, 1024));
[download]


[ar0n]

have a look at your server error log
the script i posted works fine for me...

you have to upgrade CGI.pm, (older versions lack upload() function)
the other choice you have is to use $file_name as file handle prepending "no strict;"
see "perldoc CGI" for more details.

See this node.

[ar0n]