Re: A question of style - declaring lexicals

Here's another disadvantage of style #1 - what happens if you have name reuse? For example, you have a @foo that's used throughout the file. Only, in one place, it means one thing and somewhere else it means something else.

By declaring variables as close to first use as possible, you minimize a lot of risks. And, frankly, I don't care what variables are available in a given scope. I only care what variables are being used in the snippet I'm looking at. If I have to look around without a good reason, I get pissed off.

------
We are the carpenters and bricklayers of the Information Age.

Then there are Damian modules.... *sigh* ... that's not about being less-lazy -- that's about being on some really good drugs -- you know, there is no spoon. - flyingmoose

I shouldn't have to say this, but any code, unless otherwise stated, is untested

Comment on Re: A question of style - declaring lexicals

Replies are listed 'Best First'.
Re: A question of style - declaring lexicals by Abigail-II (Bishop) on Jun 03, 2004 at 13:44 UTC
Here's another disadvantage of style #1 - what happens if you have name reuse? For example, you have a @foo that's used throughout the file. Only, in one place, it means one thing and somewhere else it means something else. Actually, I see that as an advantage of style 1. Say you have a @foo, and it's used at different places, but in the same lexical scope. If you declare it close to where it's first used, you'll get annoying warnings that you redeclare a variable (I hated that warning when it was first introduced - it was introduced before, or at the same time that `foreach my $var (LIST)` was allowed). If you declare all your variables at the top, you see you have a conflict the second time you try to declare @foo, and can pick another name. Abigail	[reply] [d/l]
Re^2: A question of style - declaring lexicals by Fletch (Bishop) on Jun 03, 2004 at 17:46 UTC
Here's another disadvantage of style #1 - what happens if you have name reuse? For example, you have a @foo that's used throughout the file. Only, in one place, it means one thing and somewhere else it means something else. Some would say that it means you should have had two varaibles	[reply]