in reply to Concurrent file access with flock()

Your file locking appears to be fine. I can't be sure, because I don't know that LOCK_EX == 2 on your system. It would be good to add use Fcntl qw(:flock); to the top and use your constants by name. I'd also encourage you to use a lexical file handle instead of localizing *FH. A lexical handle is closed when its name goes out of scope and no other references exist.

Several question that may point to the problem: Are you sure no other script is accessing the counter? Does your OS support flock in all its glory? Is this the actual code, or is it trimmed for the question?

That is some commendably clean code.

After Compline,
Zaxo

Replies are listed 'Best First'.
Re^2: Concurrent file access with flock()
by Anonymous Monk on Jun 17, 2004 at 17:54 UTC
    Hi Zaxo,

    Here's my comment:

    1. I am quite sure that LOCK_EX == 2, so it should be fine.

    2. Correct me if I am wrong, most of the example that I see uses localizing *FH for file handling issue. This will also goes out of scope since I put it inside a scope.

    3. Actually, this is not the actual code, I put it here just to simplify things. In actual, there are few different perl script that actually access the counter file, but it is access via a common package (with locking of course). I even have some script accessing the counter via mod_perl 1.99.

    4. RedHat does have support for flock(), I have been using it all the while and it doesn't give me any problems.

    Just want to know if anyone experience this kind of problem before. Anyway, thanks for your comment!

    Regards,
    Perl Beginner.