If it works, why change it. I whould do it with the .. operator.

while(<FILE>){
  if ( /^-- start foo/ .. /^-- end foo/ ){
    # do what you like to do here
  }
}
[download]