in reply to How would you go about it?
Nice code. I saw something in your code that I was doing, and lately converted. These lines:
Your use of if and unless are creating a more compact form of if (...){} else {} for calling &find. I love statement modifiers, but I now use the following form:#use default directory if argument not set on command line find(\&fileop, $opts{'directory'}) unless @ARGV; find(\&fileop, @ARGV) if @ARGV;
That way, with a true if/else variant, I never screw up the logic and inadvertently create overlapping conditions, which were difficult to debug.#use default directory if argument not set on command line find(\&fileop, @ARGV ? @ARGV : $opts{'directory'});
Yes, Aristotle said the same thing, but the key, I think, is not the needless redundancy of the code, but the danger of creating those overlapping conditions.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^2: How would you go about it?
by Aristotle (Chancellor) on Jul 26, 2004 at 17:57 UTC |