In addition to what the others have said, I'd like to point out a huge security hole. I've reformatted the code for clarity, but the following is logically equivalent to what you have:

my $dbh = DBI->connect(
    'DBI:mysql:*********', 
    '*****', 
    '*****', 
    {RaiseError => 1 , AutoCommit => 1}
) || die "Can't Connect: $!";

my $sth = $dbh->prepare(<<END_SQL);
    UPDATE inventory 
    SET img="$short_name", thumb="$short_tname" 
    WHERE partno="$img_name";
ENDSQL
$sth->execute;
[download]

Never allow user to be able to send data directly to the database like this. If you do, you open yourself up to SQL injection attacks where the attacker can insert their own SQL and run it arbitrarily against the server. You can protect against this by using the $dbh->quote method on the variables before you insert them. However, a cleaner strategy is to always use placeholders:

my $sth = $dbh->prepare(<<END_SQL);
    UPDATE inventory 
    SET    img = ?, thumb = ? 
    WHERE  partno = ?;
ENDSQL
$sth->execute($short_name, $short_tname, $img_name);
[download]

Read "Placeholders and Bind Values" in the DBI documentation for more information.

Also, we'd need to see what's in config.pl, because I suspect there are variables in there such as $doc_root which are necessary for the script to run.

  - If $query->upload('fullimage_file') || $query->upload('thumbnail_f
+ile') {
  + if ( $query->upload('fullimage_file') || $query->upload('thumbnail
+_file') ){
[download]

[frink@truth ~]$perl
if(1) { print "yeah\n"; }
yeah
[frink@truth ~]$perl
If(1) { print "no\n"; }
syntax error at - line 1, near ") {"
Execution of - aborted due to compilation errors.
[download]

If $query->upload('fullimage_file') || $query->upload('thumbnail_file'
+) {
[download]

if( $query->upload('fullimage_file') || $query->upload('thumbnail_file
+') ) {
[download]

Also the } on line 43 should be moved to line 27.

That is, instead of

if( $query->upload('fullimage_file') || $query->upload('thumbnail_file
+') ) {
my $img_name              = $query->param('item');
my $full_pic             = $query->upload('fullimage_file');
my $thumb_pic             = $query->upload('thumbnail_file');
my $fullname              = basename($full_pic);
my $thumbname              = basename($thumb_pic);
my ($F_name, $f_ext)     = split /\./, $fullname,2;
my ($T_name, $t_ext)     = split /\./, $thumbname,2;

my $short_name="$img_name\.$f_ext";
my $short_tname="$img_name\_t\.$t_ext";

my $new_name              = "$doc_root$img_folder/$short_name";
my $new_tname             = "$doc_root$img_folder/$short_tname";

if ($full_pic ne ''){
    open (OUTFILE,">$new_name");
    binmode OUTFILE;
    while ($bytesread=read($full_pic,$buffer,1024)) {
    print OUTFILE $buffer;
    }
}
if ($thumb_pic ne ''){
    open (FILE,">$new_tname");
    binmode FILE;
    while ($bytesread=read($thumb_pic,$buffer,1024)) {
    print FILE $buffer;
    }
}
}
[download]

if( $query->upload('fullimage_file') || $query->upload('thumbnail_file
+') ) {
my $img_name              = $query->param('item');
my $full_pic             = $query->upload('fullimage_file');
my $thumb_pic             = $query->upload('thumbnail_file');
my $fullname              = basename($full_pic);
my $thumbname              = basename($thumb_pic);
my ($F_name, $f_ext)     = split /\./, $fullname,2;
my ($T_name, $t_ext)     = split /\./, $thumbname,2;

my $short_name="$img_name\.$f_ext";
my $short_tname="$img_name\_t\.$t_ext";

my $new_name              = "$doc_root$img_folder/$short_name";
my $new_tname             = "$doc_root$img_folder/$short_tname";
}

if ($full_pic ne ''){
    open (OUTFILE,">$new_name");
    binmode OUTFILE;
    while ($bytesread=read($full_pic,$buffer,1024)) {
    print OUTFILE $buffer;
    }
}
if ($thumb_pic ne ''){
    open (FILE,">$new_tname");
    binmode FILE;
    while ($bytesread=read($thumb_pic,$buffer,1024)) {
    print FILE $buffer;
    }
}
[download]

davidj

Moving the line 42 } is not a good idea; then the scope of all those lexicals doesn't extend to where they are actually used.

Maybe his code that I downloaded was corrupted, because moving the } is the only way I got it to compile.

davidj