Re: RFC: Simple DBI abstraction

Code contains many hints to what happens. Or at least, it should. I think removing the word that describes what happens is a bad idea.

Insert/select/update all make it very clear what goes on. "do" does not. It is like having a $data. Nice, but what kind of data? With do, I'd want to know *what* it does. Choosing based on something as subtle as argument differences isn't good enough, in my opinion.

There's a lot that can be abstracted in SQL. SQL::Abstract and DBIx::Abstract abstract the query into a method name and data structures, Class::DBI abstracts everything into objects. But always there is a way to see exactly what goes on.

The action should never be left out, and always be explicitly stated.

Please have a look at DBIx::Simple. It can use SQL::Abstract for some abstraction, but you'll always have to tell it what to do. It won't try to choose on its own.

Which brings me to another point: IF you decide to put this on CPAN, please make sure it is in the DBIx:: namespace. Don't invent a new root namespace just because you couldn't think of a name in DBIx::, because DBIx::Abstract was already taken. Be creative. (How about DBIx::Do?)

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }

Comment on Re: RFC: Simple DBI abstraction

Replies are listed 'Best First'.
Re^2: RFC: Simple DBI abstraction by Jaap (Curate) on Sep 09, 2004 at 08:13 UTC
You make a good point here, Juerd. How about i change the do() arguments to this: `$dbh->do(tableName => "table_name", get => {...}, set => {...})` [download]	[reply] [d/l]
Re^3: RFC: Simple DBI abstraction by Juerd (Abbot) on Sep 09, 2004 at 13:35 UTC
You make a good point here, Juerd. How about i change the do() arguments to this: $dbh->do(tableName => "table_name", get => {...}, set => {...}) Better already, but when in real life is it practical to simultaneously set and get? I can't think of any situation. Thus abstracting it more, to two methods instead of one, makes sense to me: `$dbh->get("table_name", {...}); $dbh->set("table_name", {...});` [download] Which is very close to what DBIx::Simple lets you write if you have SQL::Abstract installed: `$db->select('table_name', [...]); $db->update('table_name', {...}, ...);` [download] Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }	[reply] [d/l] [select]
Re^4: RFC: Simple DBI abstraction by Jaap (Curate) on Sep 09, 2004 at 16:20 UTC
when in real life is it practical to simultaneously set and get It's not that you want to set and get, it's that you need to specify WHICH ROWS to set the data to. With get.	[reply]