Re^4: while loop returns same values

thought i would attach the enitre code

open (LIST, "<all_res");
while ($output =<LIST>) {
chomp $output;

$file = 'test.pat' ;

$file2 = $output ;

$file3 = $output . ".resauto";

open (FILE, "<$file");
open (OUT, ">TRUE_OUTPUTS");

open (FILE2, "<$file2");
open (OUT2, ">COMPARE");


while (<FILE>) {

if ($_ =~ m/^\s\s\s\s+(\d)\s+$/) {print OUT "$1\n"}

               }
close (FILE);
close (OUT);

while (<FILE2>) {


    push @col, $_ =~ m/^(\S+)/  unless ...;

}
close(FILE2);

open(COL, "<TRUE_OUTPUTS");
while(<COL>) {

      $_ =~ s/^(\S)/$1 $col[$i++]/;

     print OUT2 $_;
}
close(COL);
close(OUT2);

open (COUNT, "<COMPARE") or "Can't open COMPARE: $!";

while (<COUNT>) {

($i, $j) = split (/\s+/, $_);

if ($i == 1) {$totalinterface++};
if ($i == 0) {$totalnon++};


if ($j >= 0.5 && $i == 1) {$TP++ unless $j == 1 && $i == 1};
if ($j >= 0.5 && $i == 0) {$FP++};

if ($j <=0.499999 && $i == 1) {$FN++};
if ($j <=0.499999 && $i == 0) {$TN++};

#if ($j >= 0.5001 ) {$TP++};



$total = $TP+$FP+$FN+$TN;
 }

close(COUNT);



open (completeout, ">$file3");

print completeout    "$file2\n";
print completeout "$TP\n";
print completeout "$TN\n";
print completeout "$totalinterface\n";
print completeout "$totalnon\n";

unlink "TRUE_OUTPUTS";
unlink "COMPARE";

}
[download]

Comment on Re^4: while loop returns same values Download Code

Replies are listed 'Best First'.
Re^5: while loop returns same values by TheEnigma (Pilgrim) on Sep 14, 2004 at 13:44 UTC
I think I see some problems. In `while (<FILE2>) { push @col, $_ =~ m/^(\S+)/ unless ...; }` [download] you probably want to say `my @col`, otherwise `@col` keeps accumulating stuff from the previous pass through the first while loop. Likewise, in `while(<COL>) { $_ =~ s/^(\S)/$1 $col[$i++]/; print OUT2 $_; }` [download] you probably want to say `my $i++` so $i starts at 0 again, instead of being left with whats in it from the `while (<COUNT>)` loop. And again, in `while (<COUNT>){ ($i, $j) = ...` [download] it would be good if you used `my ($i, $j)` [download] You also create and destroy the TRUE_OUTPUTS file each time through the loop. But from what you've shown, it never changes. So it would be better to put this at the top: `open (FILE, "test.pat") or die "Can't open test.pat: $!"; open (OUT, ">TRUE_OUTPUTS") or die "Can't open TRUE_OUTPUTS: $!"; while (<FILE>) { if ($_ =~ m/^\s{4,}(\d)\s+$/) {print OUT "$1\n"} } close (FILE); close (OUT);` [download] Note that I used a constant "test.pat" since you said that doesn't change. I also added `die` and tidied up the regex by using `{4,}` to match 4 or more. Also, you forgot the `die` in `open (COUNT, "<COMPARE") or "Can't open COMPARE: $!";` And now, just to be nitpicky, $output seems like a bad variable name. I think $input_file or just $input would be better. Hope this helps. TheEnigma	[reply] [d/l] [select]
Re^6: while loop returns same values by Anonymous Monk on Sep 14, 2004 at 15:10 UTC
thanks for helping, seems to have done the trick	[reply]