Re: improve ugly flow control

How about putting a "fail" sentinel at the end of @options and in %hash, such that do_something('fail') is the same as log_failure()? That way, your loop simplifies to:

foreach (@options) {
  if(exists $hash{$_}) {  # always true for $_='fail'
    &do_something($_); last;
  }
}
[download]

Now admittedly, inserting the sentinel into @options and %hash is obnoxious and hackish, but better to have that in your data than in your code....

-- F o x t r o t U n i f o r m Found a typo in this node? /msg me % man 3 strfry

Comment on Re: improve ugly flow control Select or Download Code

Replies are listed 'Best First'.
Re^2: improve ugly flow control by Aristotle (Chancellor) on Sep 19, 2004 at 11:07 UTC
In the same vein, but along a different angle: `foreach my $i ( 0 .. $#options, 'fail' ) { if( $i eq 'fail' ) { log_failure(); last; } if( exists $hash{ $options[ $i ] } ) { do_something( $options[ $i ] ); last; } }` [download] Makeshifts last the longest.	[reply] [d/l]