Re: Being more Assert-ive with Perl

Nice :) It is readable indeed, but it could even be better. This is just a small tip, I do not want to offend you in any way, but I think

# warn the user of the wrong input and return
# false, leaving the calling routine dealing 
# with things
(defined($coin) && $coin == 25) || (warn("You must insert 25 cents"), 
+return 0);
[download]

is better written as

# warn the user of the wrong input and return
# false, leaving the calling routine dealing 
# with things
(defined($coin) && $coin == 25) || return do {warn("You must insert 25
+ cents"); 0};
[download]

IMHO, that would even be more readable

"2b"||!"2b";$$_="the question"

Comment on Re: Being more Assert-ive with Perl Select or Download Code

Replies are listed 'Best First'.
Re^2: Being more Assert-ive with Perl by stvn (Monsignor) on Sep 23, 2004 at 16:00 UTC
MUBA, No offense taken at all. I usually use `die` or throw an exception object. So the examples with `warn` and such are ones I made up when writing this. I am sure they could be improved, and I agree the `do` does make it more readable. -stvn	[reply] [d/l] [select]