in reply to Re: Advocacy of code reviews: how the heck do you do it?
in thread Advocacy of code reviews: how the heck do you do it?

I like your ideas, stvn, but I have a problem where I work: no peers. At least, not in Perl. There is only one other person in the organization who knows any Perl -- she is just beginning, and uses it only for administration tasks. Now, I've reviewed her code, at her request, many times. She has tried to review my code, but simply doesn't know enough Perl yet.

What options do I have for code review?

radiantmatrix
require General::Disclaimer;
  • Comment on Re^2: Advocacy of code reviews: how the heck do you do it?

Replies are listed 'Best First'.
Re^3: Advocacy of code reviews: how the heck do you do it?
by stvn (Monsignor) on Oct 18, 2004 at 14:46 UTC
    radiantmatrix

    Well, not having peers does present a problem here. If you have enough other coders/programmers/developers in your organization then it might be possible to just talk a little more high level with them instead of code/language specific. Really most C based languages (Java, Perl, etc.) are similar enough that a good programmer (with an open mind) can understand your perl code. I have caused much envy among Java programmer friends showing them elegant solutions using anon. subs and such, which would take a ridiculous amount of code/time to do in Java.

    I would find the best <other language> programmer you can find, and try Option 2, since a lot of the benefits of that comes from you having to explain your own code, you will likely benefit even if they don't offer too much thought.

    Personally I would really like to see a Code Review section here on Perl Monks, but that might not help you with work-related code.

    -stvn
      I have caused much envy among Java programmer friends showing them elegant solutions using anon. subs and such, which would take a ridiculous amount of code/time to do in Java
      I'm envious that you work with people who would be envious... I desperately want to work with people who aspire to improve themselves, sadly this isn't the norm...