RE: Code Clinic

I should have put these in the original post. Both are posts on perl.com, both are authored by Mark-Jason Dominus.

They give an idea of what I'm talking about (and I want to emphasize that I think the best place for it might not be its own section, but a subsection of Tutorials )

One valid worry is that there's enough opinions out there already about "how to do it", and this might end up just duplicating what goes on in the best of Seekers of Perl Wisdom threads; the original post is clear about the goals, and provides some code that does not work as the author wants it to, and various monks chime in with their proposed solutions. I envision rolling up the process a bit, in that the first step would be posted by someone who took "bad" code and generated something he or she is proud of out of it.
MJD's second "program repair shop"

MJD's first "program repair shop"

Philosophy can be made out of anything. Or less -- Jerry A. Fodor

Comment on RE: Code Clinic

Replies are listed 'Best First'.
RE: Code Clinic by Dominus (Parson) on Nov 16, 2000 at 00:48 UTC
You guys inspired me, so I wrote another Program Repair Shop and Red Flags article which went up on `www.perl.com` today. The article takes an old crufty piece of Perl 4 code and tries to improve it. Here's the description from the web site: Once again I take a real program written by a genuine novice and show how to clean it up and make it better. This time we turn a perl4 library into a Perl 5 object-oriented module. I show how to recognize some "red flags" that are early warning signs that you might be doing some of the same things wrong in your own programs. Enjoy.	[reply]
RE: Code Clinic by Dominus (Parson) on Nov 11, 2000 at 02:35 UTC
Those articles were very popular, and I'd really like to do some more of them. The problem is that it's difficult to find appropriate code samples to discuss. I don't want to use anyone's code without permission. Does anyone have any suggestions about where I could find some novices who would be willing to contribute brief (20-50 lines) samples of code for review on www.perl.com?	[reply]
RE (tilly) 2 (irony): Code Clinic by tilly (Archbishop) on Nov 10, 2000 at 07:33 UTC
I have always been bemused by the fact that even though both articles were good, neither used strict. However the first one in particular is worth reading. Not so much for the information in it as the metrics that he is using. It is not so much, "This is better" as, "This is what I look for in deciding what is better." That is an important step to take.	[reply]