Re^2: Error(?): "CV isn't complete"?

Nicely spotted, Thanks++.

I thought that I was misunderstanding the XS code when it appeared to be issuing the error unconditionally.

I never even looked at the "bugs" section. I think that's because I took the error "CV isn't complete", to mean that there was something wrong with the CV itself, rather than something wrong with the way Devel::Size was using or reporting it.

Maybe the message should read "Size for CV is incomplete", that would at least give some clue as to where and what the message meant.

Even better if it read "Devel::Size: Sizes for CVs are incomplete".

Indeed, I will change mine to read that way, and offer it as a patch to the owner. Along with something that I feel is sadly lacking from the documentation of many (almost all?). A simple section headed:

Messages: warning and error texts originating from this module.

It would make it a lot easier to find if such texts were in the POD (and generated HTML). I did a grep of my local Perl directory before posting the OP, but I didn't find it because I had the PPM version of the module, which doesn't contain the source. It does contain the HTML though.

Examine what is said, not who speaks.

"But you should never overestimate the ingenuity of the sceptics to come up with a counter-argument." -Myles Allen
"Think for yourself!" - Abigail "Time is a poor substitute for thought"--theorbtwo "Efficiency is intelligent laziness." -David Dunham
"Memory, processor, disk in that order on the hardware side. Algorithm, algorithm, algorithm on the code side." - tachyon

Comment on Re^2: Error(?): "CV isn't complete"?

Replies are listed 'Best First'.
Re^3: Error(?): "CV isn't complete"? by Elian (Parson) on Nov 19, 2004 at 20:20 UTC
Note that you can disable this warning by: `$Devel::Size::warn = 0` [download] though I see I forgot to document that. This is the sort of thing that, in general, warrants a bug report. (The only reason I noticed the thread here was sheer boredom -- if there's an email address in the docs for a module behaving oddly, and I double-checked and there was, firing off mail isn't out of order...)	[reply] [d/l]
Re^4: Error(?): "CV isn't complete"? by BrowserUk (Patriarch) on Nov 20, 2004 at 02:36 UTC
Had it been anyone other than you I might have settled for just an email. As it was, and given your workload, I wanted at least offer a patch properly. Get the latest sources; test on an up-to-date copy of Perl etc. Which meant downloading bleed-perl and I tend to leave big downloads to the weekend. One of the constraints of a narrow pipe. Quite how you find the time to be bored amazes me, given your prolific involvement in so many things. Update: Done. Examine what is said, not who speaks. "But you should never overestimate the ingenuity of the sceptics to come up with a counter-argument." -Myles Allen "Think for yourself!" - Abigail "Time is a poor substitute for thought"--theorbtwo "Efficiency is intelligent laziness." -David Dunham "Memory, processor, disk in that order on the hardware side. Algorithm, algorithm, algorithm on the code side." - tachyon	[reply]
Re^5: Error(?): "CV isn't complete"? by Elian (Parson) on Nov 27, 2004 at 21:48 UTC
I got the patch and applied it, so the errors are a bit more distinguishable. I also, while I was at it, added in proper (mostly) sizing for filehandles and globs. (Globs were silently wrong -- sizing a glob should have counted everything in the glob, but it didn't, so the totals were a bit low. Now it does, and they aren't)	[reply]
Re^5: Error(?): "CV isn't complete"? by Elian (Parson) on Nov 22, 2004 at 15:08 UTC
The problem with being involved with so many things is that sometimes they're all stuck waiting on other things, or in the middle of some build or other that's long enough to trigger the "bored now" reflex, but not long enough to actually do anything meaningful. At those times I browse the web. :) I got the patch for this. Next time I'm waiting on a 15 minute compile I'll look at it, apply it, and cut a new release. Might fix up some of the other semi-implemented bits while I'm at it. (CVs aren't the only thing that Devel::Size can't get a good handle on)	[reply]