Re^3: Hash Trouble

The new code was missing the association of $val

Not at all. There's no reason to do
$val = $msg;
$analysis{$key} = $val;
when
$analysis{$key} = $msg;
suffices.

For me I would rather build one hash table instead of multiple hash tables and then merging them. To me it seems like a waste what are your thoughts?

To which multiple hashes are you refering? You mean if you if you were to keep the timestamp? You could do something like:

            while(<RPT>)
            {
                chomp;
                if (/^(\D+.*\d{4}\s+)(\D+.*)(\w{11})$/)
                {
                    my $timestamp = $1;
                    my $msg       = $2;
                    my $key       = $3;
                    fmt_rpt($msg);
                    if (exists($analysis{$key}))
                    {
                        $analysis{$key}[1] .= $msg;
                    }
                    else
                    {
                        $analysis{$key} = [ $timestamp, $msg ];
                    }
                }
                else
                {
                    print "Program Error 2\n";
                    exit 1;
                }
[download]

See perllol for details. This would be a HoA (Hash of Arrays), which is similar to the mentioned AoA (Array of Arrays).

Comment on Re^3: Hash Trouble Select or Download Code

Replies are listed 'Best First'.
Re^4: Hash Trouble by tc1364 (Beadle) on Nov 19, 2004 at 18:55 UTC
You are right... my blunder. No what I meant about the Hash thing was someone building a hash table for each file. In my case there are multiple files so I would perfer looping through for example the log files from multiple days and make one hash table. This section of code will be used for analysis and once certain peg counts are reached, email the responsible part will the information. Thank you for all of your assistance and words of wisdom, Terry.	[reply]
Re^5: Hash Trouble by ikegami (Patriarch) on Nov 19, 2004 at 19:09 UTC
oh! well that's pretty simple, and you have a few alternatives. `{ local @ARGV = ('file1', 'file2', ...); while (<>) { chomp; ... } }` [download] or `foreach $filename ('file1', 'file2', ...) { local RPT; open(RPT, '<', $filename) or die("...\n"); while (<RPT>) { chomp; ... } }` [download] or `sub read_log { my ($filename, $analysis_ref) = @_; local RPT; open(RPT, '<', $filename) or die("...\n"); while (<RPT>) { chomp; ... if (exists($$analysis_ref{$key})) { $$analysis_ref{$key} .= $msg; } else { $$analysis_ref{$key} = $msg; } ... } } my %analysis; read_log($_, \%analysis) foreach ('file1', 'file2', ...);` [download]	[reply] [d/l] [select]