in reply to use strict and TokeParser

You can make this easier and avoid those types of errors by switching to HTML::TokeParser::Simple and some defensive programming (it's easier to read, too.)

use strict;
use HTML::TokeParser::Simple;

my $filepath = "c:/folder/file.html";

my $stream = HTML::TokeParser::Simple->new($filepath) or die $!;
while (my $token = $stream->get_token){
    next unless $token->is_start_tag('a');
    print "PDF link!\n" if $token->get_attr('href') =~ m/\.pdf/;
}

[download]

Cheers,
Ovid

New address of my CGI Course.

Replies are listed 'Best First'.
Re^2: use strict and TokeParser
by PodMaster (Abbot) on Nov 24, 2004 at 08:04 UTC
    I would strongly reccomend against HTML::TokeParser::Simple. While initially it looks very useful, it is very unstable and it breaks too frequently for my taste, for example the straw that broke the camels back. Instead of trying to figure out what was broken in HTML::TokeParser::Simple, I simply went back to using HTML::TokeParser. Nothing to debug, nothing to worry about anymore.

    MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!"
    I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README).
    ** The third rule of perl club is a statement of fact: pod is sexy.

[reply]
[reply]
        Sorry for the late reply. Yes, that is a bug report in HTML::LinkExtractor (my module). That bug was caused by (at that time) latest version of HTML::TokeParser::Simple. I hastily got rid of HTML::TokeParser::Simple, uploaded a new version of my module and forgot about it until my reply above (sorry if Instead of trying to figure out what was broken in HTML::TokeParser::Simple was vague).

        It happens sometimes, I should've been more verbose.

        MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!"
        I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README).
        ** The third rule of perl club is a statement of fact: pod is sexy.

[reply]

      So you send me a private message telling me there are, in fact, problems with my module but you refuse to tell me what the problems are. If you can give me some clear, specific issues with HTML::TokeParser::Simple that need to be resolved, I'd be happy to deal with those issues. The truth is, the only bug report I can ever remember getting about this module was from you and that was a couple of years ago. Even then it was not a bug but a bad design decision on my part and I fixed it rather promptly.

      So please tell me what the problems are with this module. If you can't think of any, don't go spreading FUD. If you can think of some, why didn't you tell me what they are before you started trashing my module? I didn't write the thing just to say I have something on the CPAN. I want it to actually be useful.

      Update: After digging around, I find a cryptic entry in your changes file for HTML::LinkExtractor. All it says is that you stopped using HTML::TokeParser::Simple back in September of this year. There's no mention in the associated bug report that my module was at fault and had you even done something as simple as forward me the link, I would have happily fixed it. Now I'm going on vacation and (if the code is in fact buggy) I have to leave buggy code on the CPAN until I get back.

      Cheers,
      Ovid

      New address of my CGI Course.

[reply]

In Section Seekers of Perl Wisdom