Re: Debugging a login script using MySQL

I do not know why your script dies, but are you sure you really want to use it? It seems very insecure.

It makes cookies with the user's password, which as a result will be sent around all the time. (Actually, the MD5 of a password, which is better, but still not good)

It is vulnerable to SQL injection attacks:

my $sth = $dbh->prepare("SELECT * FROM $users_table WHERE username = '
+$username' AND user_password = '$userpass'");
        $sth->execute;
[download]

A user called ' or 1=1 -- could probably login without a password. That should really be:

my $sth = $dbh->prepare("SELECT * FROM $users_table WHERE username = ?
+ AND user_password = ?");
$sth->execute($username, $userpass);
[download]

It looks like any user with a cookie "user_id" is assumed to be logged in. It is easy for users to make such a cookie by themselves.

Comment on Re: Debugging a login script using MySQL Select or Download Code